Fix Off Canvas Editor add submenu item option #46562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +29 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
talldan
requested review from
MaggieCabrera,
getdave,
draganescu and
scruffian
getdave
approved these changes
Dec 15, 2022
| @@ -145,7 +144,7 @@ function ListViewBlock( { | |||
|
|
|||
| const { isTreeGridMounted, expand, collapse } = useListViewContext(); | |||
|
|
|||
| const isEditable = blockName !== 'core/page-list-item'; | |||
| const isEditable = block.name !== 'core/page-list-item'; | |||
There was a problem hiding this comment.
Aside: I added this line to #46166
| block.name === | ||
| 'core/navigation-submenu' | ||
| ) { | ||
| const updateSelectionOnInsert = false; |
There was a problem hiding this comment.
Given the API this is very helpful 🙇
Comment on lines
+372
to
+373
| block.name === | ||
| 'core/navigation-submenu' |
|
Thanks for fixing this. I had a hunch that the problem was that the block wasn't defined but I wasn't sure exactly what line was relying on that. Are you able to explain it? |
|
@scruffian The change in #46541 results in the off canvas editor using a slimmed down version of the block hierarchy that only has |
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Fix Off Canvas Editor add submenu item option * Fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46553
Why?
This feature stopped working as a side effect of not passing the entire block data through the off canvas list view.
How?
Use a selector to get the block information from the block editor store.
I've also changed a minor aspect of how this feature works. It was originally creating a new submenu block every time, even when the block was already a submenu block. That's a little inefficient, as it'll result in the block getting a new client id.
If the block is already a submenu, it now only inserts a new navigation link.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2022-12-15.at.11.41.38.mp4